Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove interval and give more time to unsync #55006

Merged
merged 4 commits into from
Sep 24, 2024
Merged

test: remove interval and give more time to unsync #55006

merged 4 commits into from
Sep 24, 2024

Conversation

pmarchini
Copy link
Member

This PR should address #54807.

I'm leaving this in Draft while testing more extensively 🚀

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 19, 2024
@pmarchini pmarchini marked this pull request as ready for review September 19, 2024 10:25
@RedYetiDev RedYetiDev added the test_runner Issues and PRs related to the test runner subsystem. label Sep 19, 2024
RedYetiDev
RedYetiDev reviewed Sep 19, 2024
View reviewed changes
test/parallel/test-runner-watch-mode-complex.mjs Outdated
Comment on lines 79 to 82
await new Promise((resolve) => setTimeout(() => {
unlinkSync(fileToDeletePathLocal);
resolve();
}, common.platformTimeout(1000)));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/Should this be simplified with node:timers/promises?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think about it, thanks for the suggestion, I'll take a look 😁

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would using node:fs/promises be enough here? It seems weird to have to put a sync operation in an async one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aduh95, yes, no problem at all.
The only important logic is the "sleep" after the delete to ensure that the watcher has received the event and completed the test run before proceeding.
Thanks for your feedback, I'll fixit ASAP 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just update 😁

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (0d4387e) to head (e654e80).
Report is 84 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55006      +/-   ##
==========================================
+ Coverage   88.04%   88.25%   +0.20%     
==========================================
  Files         652      651       -1     
  Lines      183765   183877     +112     
  Branches    35863    35857       -6     
==========================================
+ Hits       161789   162273     +484     
+ Misses      15229    14898     -331     
+ Partials     6747     6706      -41

see 108 files with indirect coverage changes

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62642/

cjihrig
cjihrig reviewed Sep 21, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments.

If this fixes #54807, can you add that to this PR so that the issue gets closed.

test/parallel/test-runner-watch-mode-complex.mjs Outdated
Comment on lines 18 to 20
function wait(ms) {
return new Promise((resolve) => setTimeout(resolve, ms));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use setTimeout() from node:timers/promises for this exact functionality.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 😁

test/parallel/test-runner-watch-mode-complex.mjs Show resolved Hide resolved
cjihrig
cjihrig approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jakecastelli
Copy link
Member

I see this test fail a lot on windows platform, could we queue a stress test?

@aduh95
Copy link
Contributor

aduh95 commented Sep 23, 2024 •
edited by cjihrig
Loading

Stress test CI: https://ci.nodejs.org/view/Stress/job/node-stress-single-test/538/ 🟢

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use the flush option of writeFile to cause an fsync: https://nodejs.org/docs/latest/api/fs.html#fspromiseswritefilefile-data-options.

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62715/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 24, 2024 •
edited by jakecastelli
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/62725/ 💚

@cjihrig cjihrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Sep 24, 2024
@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 24, 2024
@nodejs-github-bot nodejs-github-bot merged commit 02e8972 into nodejs:main Sep 24, 2024
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 02e8972

targos pushed a commit that referenced this pull request Oct 4, 2024
@pmarchini @targos
test: remove interval and give more time to unsync
80da599 
PR-URL: #55006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@pmarchini @louwers
test: remove interval and give more time to unsync
ba0692d 
PR-URL: nodejs#55006
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@aduh95 aduh95 aduh95 left review comments

@mcollina mcollina mcollina left review comments

@jakecastelli jakecastelli jakecastelli approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. test_runner Issues and PRs related to the test runner subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pmarchini @nodejs-github-bot @jakecastelli @aduh95 @mcollina @jasnell @cjihrig @RedYetiDev